Skip to content

Reveal diagnostics below the visible editor on WebKit #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chumaniac merged 1 commit into from
Nov 11, 2026
Merged

Reveal diagnostics below the visible editor on WebKit #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions browser/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,17 @@ locate.addEventListener("click", () => {
if (!errorLocation) return;
input.focus();
input.setSelectionRange(errorLocation.start, errorLocation.end);
// WebKit can move the selection without scrolling a wrapped textarea.
const measure = input.cloneNode(false) as HTMLTextAreaElement;
measure.removeAttribute("id");
measure.className = "diagnostic-measure";
measure.setAttribute("aria-hidden", "true");
measure.tabIndex = -1;
measure.style.width = input.clientWidth + "px";
measure.value = input.value.slice(0, errorLocation.start) + "\u200b";
input.after(measure);
input.scrollTop = Math.max(0, measure.scrollHeight - input.clientHeight / 2);
measure.remove();
});
const fields = document.querySelector<HTMLElement>("#fields")!;
const example = "---\nname: inventory-check\ndescription: 对照清单核对库存。\n---\n\n先读取清单，再逐项核对应有与实收数量。";
Expand Down
11 changes: 11 additions & 0 deletions browser/style.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading