Repository navigation
Say that Chroma 1.3.0 applies the space of a schema only when the schema also turns an index on or off, and test it - #128
Merged
Merged
Conversation
…his client and in plain HTTP
…ema also turns an index on or off, and test it
Laurianti
force-pushed
the
space-in-schema-130
branch
from
October 13, 2026 08:01
02edd24 to
5c5f242
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The compatibility correction is consistently documented and covered by targeted tests, with only a minor naming concern.
1 open finding
What changed in this PR
Clarifies Chroma 1.3.0’s conditional handling of schema-defined spaces and adds regression coverage.
Changes:
- Corrects compatibility documentation and diagnostics.
- Tests space handling with an explicitly disabled index.
- Refactors shared schema-space test logic.
| File | Description |
|---|---|
docs/sparse-vectors-and-schema.md |
Documents Chroma 1.3.0 behavior. |
docs/COMPATIBILITY.md |
Updates the compatibility matrix. |
ChromaDB.Client/ChromaClient.cs |
Clarifies diagnostics and comments. |
ChromaDB.Client.Tests/SparseVectorsAndSchemaTests.cs |
Updates diagnostic assertions. |
ChromaDB.Client.Tests/ClientTests.cs |
Adds integration coverage. |
ChromaDB.Client.Tests/ChromaTestsBase.cs |
Clarifies version gating. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Laurianti
marked this pull request as ready for review
October 13, 2026 09:06
AnisaHaxhialushi
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Chroma 1.3.0 applies the space of a collection created with a schema only when the schema also turns an index on or off; with the space alone it keeps
l2.docs/COMPATIBILITY.mdsays that 1.3.0 applies it in the request of this client and in plain HTTP, and the client messages and comments say that only 1.3.2 and later apply it.Measured on 13 October 2026: a schema with the space
cosineon#embedding, a record[1, 0]and a query of[0, 1], whose distance is 1 with cosine and 2 with l2. In plain HTTP:l2, distance 2.0cosine, distance 1.0#documentcosine, distance 1.0cosine, distance 1.0cosine, distance 1.0cosine, distance 1.0cosine, distance 1.0cosine, distance 1.0cosine, distance 1.0cosine, distance 1.0With the space alone, 1.3.0 keeps
l2also with this client and with the Python client 1.3.0, on fresh containers, three times each.Before:
docs/COMPATIBILITY.mdsaid that 1.3.0 applies the space in the request of this client and in plain HTTP. The message ofCreateCollectionAsyncandGetOrCreateCollectionAsyncfor another space said "only Chroma 1.3.2 and later apply the space with a schema".Now:
docs/COMPATIBILITY.md,docs/sparse-vectors-and-schema.md, the message and the comments say that 1.3.0 applies the space only when the schema also turns an index on or off, and that 1.3.2 and later always apply it. No change of behavior.Tests:
mainand passes with the change.