Repository navigation
Merged
Conversation
…ame first, so a collection that does not exist throws
There was a problem hiding this comment.
🟢 Approval recommended
The behavior, regression coverage, and documentation are aligned; only a non-blocking async-test cleanup remains.
1 open finding
What changed in this PR
Fixes zero-limit reads for collection clients created by name by resolving the collection before returning an empty result.
Changes:
- Moves the zero-limit shortcut inside the collection operation wrapper.
- Adds regression coverage for nonexistent named collections.
- Updates query and compatibility documentation.
| File | Description |
|---|---|
ChromaDB.Client/ChromaCollectionClient.cs |
Resolves named collections before zero-limit returns. |
ChromaDB.Client.Tests/CollectionClientGetTests.cs |
Tests the missing-collection behavior. |
docs/queries-and-filters.md |
Documents zero-limit named-client semantics. |
docs/COMPATIBILITY.md |
Updates the KD-13 workaround description. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…hronous, as it awaits nothing
AnisaHaxhialushi
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes
GetAsyncwith a limit of 0 on a collection client made by name, when the collection does not exist.GetAsync(limit: 0)without any request, also when the collection did not exist.ChromaException. A limit of 0 still sends no get, since Chroma 0.6.3 would take it as no limit.limit: 0as it is, and on Chroma 0.6.3 gets every record back; this client sends no get, and throws when the collection does not exist.CollectionClientGetTests.GetWithALimitOf0ByNameOnACollectionThatDoesNotExist, which fails on main, on Chroma 1.5.9 and on Chroma Cloud; the get tests pass on Chroma 0.6.3 too.docs/queries-and-filters.md, and the column of the client in the KD-13 row ofdocs/COMPATIBILITY.md, which said "without a request".