Skip to content

Christianrosewich security audit fixes #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChristianRosewich merged 2 commits into from
Aug 12, 2026
Merged

Christianrosewich security audit fixes #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9375fa8
fix: address codeql warning alerts #20
Aug 12, 2026
8e887bc
Potential fix for code scanning alert no. 9509: Invalid string format…
ChristianRosewich Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions CSharpBible/SomeThing/Statistic4/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,11 @@
if (arg < 0 || arg >= templates.Length)
throw new IndexOutOfRangeException($"Template index {arg} out of range.");
string tmpl = templates[arg];
Console.WriteLine(string.Format(CultureInfo.InvariantCulture, tmpl, lastObj));
System.Diagnostics.Debug.WriteLine(string.Format(CultureInfo.InvariantCulture, tmpl, lastObj));
string formatted = tmpl.Contains("{", StringComparison.Ordinal)
? string.Format(CultureInfo.InvariantCulture, tmpl, lastObj)
Comment thread
ChristianRosewich marked this conversation as resolved.
Dismissed
: tmpl;
Console.WriteLine(formatted);
System.Diagnostics.Debug.WriteLine(formatted);
}
else
{
Expand Down
4 changes: 2 additions & 2 deletions GenFreeWin/GenDBImplOLEDB/Data.DB/OleDbStatementRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@
public IDbCommand CreateQuery(IDbConnection dbConnection, string sTable, IEnumerable<string>? arrFields = null, IEnumerable<IDbFilterClause>? arrFilters = null, int? iLimit = null, object? offset = null)
{
var sFields = (arrFields?.Count() ?? 0) == 0
? "*"
: string.Join(",", arrFields.Select(QuoteIdentifier));
? "*"
: string.Join(",", arrFields.Select(QuoteIdentifier));
Comment thread
ChristianRosewich marked this conversation as resolved.
Dismissed
var xBuilder = new StringBuilder($"SELECT {sFields} FROM {QuoteIdentifier(sTable)}");
AppendFilters(xBuilder, arrFilters);

Expand Down
1 change: 0 additions & 1 deletion GenFreeWin/GenFreeWin/Gen_FreeWin/ViewModels/OrtsVerViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2106,7 +2106,6 @@ public void ListBox4_DoubleClick(object sender, EventArgs e)
// break;
//}
end_IL_0001_3:
;
}
[RelayCommand]
public void OpenDistancePanel()
Expand Down
3 changes: 1 addition & 2 deletions GenFreeWin/GenFreeWin/Gen_FreeWin/ViewModels/RahmenViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,8 +331,7 @@
{
_ = DataModul.Link.Delete(Modul1.FamInArb, Modul1.PersInArb, Modul1.eLKennz);
View.Close();
short Rich;
Familie.Default.Fameinlesen(Modul1.FamInArb, out Rich);
Familie.Default.Fameinlesen(Modul1.FamInArb, out short rich);
}
}
}
Expand Down
Loading