Fix: Crash in deep_scan, validate LLM output, ruff cleanup - #1
Open
Chocapikk wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks @Chocapikk. |
Contributor
Author
|
Bro tu cherry-pick les patterns et le cache mais tu laisses les bug fixes? 😂 Le fingerprint threshold à 0.05 c'est 5% de similarité, ça matche n'importe quoi. Le skip pattern bouffe les security releases. Et deep_scan.py a une variable undefined qui crash si tu tombes dessus. Le ruff c'est 41 issues dont des unused imports et des f-strings vides. Fais confiance stp gro 😂😂 tu veux que je split en PRs séparées ou tu reprends le reste? |
- Fix undefined suspects_count in deep_scan.py (crashes on progress print) - Remove unused raw_combined variable in deep_scan.py - Add confidence validation (HIGH/MEDIUM/LOW) in analyze.py - Add diff truncation marker for LLM context awareness - Fix 32 ruff issues across 11 files (unused imports, f-strings without placeholders)
Chocapikk
force-pushed
the
improve-heuristics
branch
from
April 16, 2026 18:30
ab21dfd to
e32c610
Compare
This was referenced Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deep_scan.py:suspects_countused before assignmentWhat's NOT in this PR
Patterns, thresholds, and skip pattern changes from the previous version have been dropped per your feedback. Specifically:
any()/list comprehension refactors: kept your styleChanges
Bug fixes
deep_scan.py:suspects_countwas referenced before assignment on progress print (line 149), crashes on first batch of 50 commits. Replaced withlen(suspects)deep_scan.py: removed unusedraw_combinedvariableanalyze.py: LLM confidence output now validated to HIGH/MEDIUM/LOW, falls back to LOW on garbageanalyze.py: diff truncation adds[diff truncated]marker so the LLM knows context is incompleteRuff (32 fixes)
RATE_LIMIT_DELAY,Path,os,sys,date,defaultdict,README_DAYS_SHOWN,get_advisories_for_date,get_recent_dates,get_all_advisoriesexcinfetch.pyTest plan
python -m src.deep_scanon a test repo, confirm no crash on progress outputruff check src/- should return 0 errors