Skip to content

test(client): lock JSON-RPC error fallback (upstream on hold) - #1

Draft
Chris0Jeky wants to merge 1 commit into
mainfrom
cursor/fix-streamable-http-jsonrpc-error-1862-6afb
Draft

Chris0Jeky wants to merge 1 commit into
mainfrom
cursor/fix-streamable-http-jsonrpc-error-1862-6afb

Conversation

@Chris0Jeky

@Chris0Jeky Chris0Jeky commented Sep 18, 2026

Copy link
Copy Markdown
Owner

This fork-only draft retains three locking tests for the representative buffered, unknown-length HttpContent, and HTTP/1.1 chunked discovery-error responses. No production transport code changed.

Previously recorded at 06872d895749d0b8b2c981344b9b9ecbc6509c16, based on upstream 324ccd83c357acf611e1cf3a6935a945ee600442: 3 tests passed on net10.0. The reported modelcontextprotocol#1862 failure did not reproduce. These results were not rerun during the 18 September research review.

dotnet test tests/ModelContextProtocol.Tests/ModelContextProtocol.Tests.csproj -f net10.0 --filter "FullyQualifiedName~StreamableHttpChunkedJsonRpcErrorTests"

Upstream remains on hold. Coordinate with upstream PR #1875 rather than opening a duplicate transport patch. Fork research PR #2 contains the comparison, additional candidates and local-agent handoff.

Before reusing these tests, review fixture exception handling, connection-task cleanup, the hard-coded discovery ID, and stale early-response comments. Final negotiated version alone is weaker evidence than asserting delivery of the correlated error. The loopback is synthetic, not a Fabric capture. Genuine net8.0/net9.0 and Windows net472 execution remain unverified by this review.

The earlier description also recorded delayed-body and UTF-8 BOM experiments as passing, without retained extra tests. Treat those as prior notes, not new verification.

AI assistance was used for the existing tests and this research update. No claim of a production fix or new .NET test run is made.

…extprotocol#1862)

Add buffered, unbuffered, and loopback chunked coverage for an HTTP 200
application/json -32600 discover reply so the initialize fallback stays
wired. The reported no-reply failure did not reproduce on current main.

Co-authored-by: Cristian Tcaci <Chris0Jeky@users.noreply.github.com>
@Chris0Jeky Chris0Jeky changed the title test(client): lock Streamable HTTP JSON-RPC error fallback (#1862) test(client): lock JSON-RPC error fallback (upstream on hold) Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants