fix(audit): bind history to query and credential lifetimes - #3345
Chris0Jeky wants to merge 8 commits into
Conversation
99bd34e to
c427730
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c4277303ec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| function retryEmptyActiveRead(): void { | ||
| const retry = currentRead && entries.value.length === 0 ? currentRetry : null |
There was a problem hiding this comment.
When board A's rows remain in entries while a request for board B is pending, a same-user token rotation makes this condition skip the retry solely because the old rows are nonempty. invalidateCurrentRead() then retires B's request, so its eventual result cannot commit; because handleFetchClick already changed the route and loading becomes false, the Activity surface indefinitely renders board A's audit rows under board B's selection. Track whether the retained rows belong to the active query, or retry every active read while preserving settled rows.
Useful? React with 👍 / 👎.
c427730 to
4835ffe
Compare
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Closes #3344. Related residual: #3352.
Summary
Binds the one shared Activity history surface to one current query and session lifetime:
Test-first evidence
Initial test-only head
3980e1e3e234a251cd89cad270b8d0ab86c3e5f2produced five intended ownership failures. Review-regression head93c20b679888394200354d80040e7f3c7dd5c353ran canonical Ubuntu/Windows frontend qualification; Ubuntu JUnit recorded 7,156 tests, exactly 2 failures, 0 errors, both loaded-history preservation cases.Issue #3352 added test-only head
85cf369ddd11dfe0a91052eb1523efbddf904a7c, covering token rotation during an empty initial history read. A dependency-free actual-module runner changed from one API call with loading false after rotation to two calls with old settlement suppressed and the fresh-token result installed.Supplemental execution does not replace hosted project qualification.
Current head and remaining gates
Exact final head:
99bd34e749e995104032e9b4a5c54df875845d46Keep draft until this exact head passes Smart CI, Extended and the complete Required CI matrix on Ubuntu and Windows, followed by fresh-context review.
No transport cancellation, API/DTO/route/schema/dependency/workflow or server-authorization change. Green CI is qualification evidence, not merge authorization.