fix(board): preserve column and assignment save ownership - #3315
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a1264abc84
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ing' into codex/3314-route-recovery
|
Required run 35766201480 at head 7ed5732 reached the Windows API test step's 45-minute timeout. The diagnostics show 1,713 passed tests and continued progress immediately before cancellation. The last observed assignment concurrency case started only 2.5 seconds before cancellation; there is no assertion failure or established hung test. The missing TRX and timing artifact are downstream consequences. Runner context reports four CPUs, 17.17 GB total memory and 13.7 GB available before execution, with no OOM signal. The backend tree still matches the already-qualified parent. One rerun of the same-head Windows job is now underway to distinguish a reproducible runtime problem from run-to-run variation. This is not a flaky classification, and the PR remains unmerged until the required gate passes. The failed log and six diagnostic artifacts are preserved locally under the session-mutations worktree's |
|
Merged and reconciled: #3315 landed at 346b3c7, preserving the assignment source #3313 and column ordering history. Required CI 35766201480 attempt 2 passed at head 7ed5732. The original Windows API timeout was investigated; the unchanged-head rerun passed, while the original runtime cause remains unresolved. It is not classified as flaky. Local final proof was 7,362 frontend passes, three existing skips, build/typecheck/lint/docs checks, four passing Chromium journeys, and clean independent source/integration reviews. #3314 and #3311 are closed; both PRs and both issues are Done with their original priorities. The post-merge checkpoint found zero unresolved review threads and no new substantive feedback on either PR. The owned integration claim is released. Before removing the completed worktree with plain git worktree remove, all 27 .runtime files and the browser result were copied and hash-verified under C:/Users/jekyt/source/Taskdeck/.runtime-codex/2026-09-22-hard-impact/board-integrated/. The cleanup manifest records exact paths and hashes. Existing worktrees and primary user edits remain untouched. OUTSTANDING_TASKS.md retains the separate owner actions; descendant #3358/#3359 maintainer review is still pending. |
Column writes could start after their board screen had closed, and a removed column lane could clear the navigation guard for an assignment save already sent to the server. This integrates the repaired column lane with PR #3313's request-owned assignment registry, preserving every source commit.
Validation at final integration head
7ed57325cf03ce1548418242531c2ae4125efb8a, based on308434f523a31864a43672d68ad5a315121c5dae:A submitted server write cannot be cancelled by retiring its UI owner. Broader card/comment/label/board lifetime work remains #3306, and shared-loading arbitration remains #3305. No human approvals in OUTSTANDING_TASKS.md are inferred or closed.
Closes #3314
Closes #3311