Skip to content

fix(comments): order shared cache settlements - #3304

Open
Chris0Jeky wants to merge 12 commits into
mainfrom
codex/3303-comment-cache-ordering
Open

Chris0Jeky wants to merge 12 commits into
mainfrom
codex/3303-comment-cache-ordering

Conversation

@Chris0Jeky

@Chris0Jeky Chris0Jeky commented Sep 20, 2026

Copy link
Copy Markdown
Owner

Summary

Hardens the shared per-card comment cache against late reads, overlapping writes, board revisits, same-board refreshes, and session changes:

  • only the latest overlapping read for a card may commit;
  • successful mutations invalidate reads that began against an older snapshot;
  • board-visit generations distinguish A→B→A and logout/login even when the board id repeats;
  • same-board detail refreshes may receive a successful in-flight create/update/delete into their newly installed cache;
  • successful writes from an older visit trigger a bounded authoritative reconciliation only when that same board is currently reopened;
  • same-comment update/delete requests serialize so server commit order follows user intent despite no revision/If-Match field;
  • queued writes recheck the initiating visit before transport starts, preventing pre-logout intent from using later-session credentials;
  • the first, unqueued write starts transport synchronously;
  • create deduplicates by stable comment id.

Tests

Focused regressions cover stale reads after create/update/delete, out-of-order reads, navigation and A→B→A visits, same-board refresh before write settlement, old-visit post-write reconciliation, stable-id deduplication, reverse-order same-comment intents, and cancellation of queued work after session replacement.

Verification

Exact head: 66e725d563e5f7d3582196346bb84e5d0adc87ce

  • Smart CI Self-Test run 35531671285: success.
  • CI Extended run 35531671492: success.
  • Required CI run 35531671472: success across frontend lint/typecheck/build/full tests on Ubuntu and Windows, backend unit/API integration on Ubuntu and Windows, architecture, migrations, containers, dependency/SAST/secret scans, docs governance, worktree contracts and E2E smoke.
  • All five Codex findings across the review rounds are addressed with dedicated regressions, replied to, and resolved.
  • Fresh exact-head diff review completed; no DTO, route, migration, control-plane or canonical-document changes.

Closes #3303

@Chris0Jeky
Chris0Jeky marked this pull request as ready for review September 20, 2026 15:13
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 20, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-20T21:54:21.082899Z 66e725d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2b21dddebf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread frontend/taskdeck-web/src/store/board/cardCommentStore.ts Outdated
Comment thread frontend/taskdeck-web/src/store/board/cardCommentStore.ts Outdated
@Chris0Jeky
Chris0Jeky marked this pull request as draft September 20, 2026 16:39

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6c72a6b13f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread frontend/taskdeck-web/src/store/board/cardCommentStore.ts Outdated
@Chris0Jeky
Chris0Jeky marked this pull request as draft September 20, 2026 17:16
@Chris0Jeky
Chris0Jeky marked this pull request as ready for review September 20, 2026 18:31

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cae9a12194

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread frontend/taskdeck-web/src/store/board/cardCommentStore.ts Outdated
Comment thread frontend/taskdeck-web/src/store/board/cardCommentStore.ts Outdated
@Chris0Jeky
Chris0Jeky marked this pull request as draft September 20, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending

Development

Successfully merging this pull request may close these issues.

Late comment reads can erase newer comment mutations from the shared cache

1 participant