Skip to content

🐛 (release-rw): Gate docs-build/docs-preview on intent.yaml artifacts.docs != skip #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chisanan232 merged 3 commits into from
May 26, 2026
Merged

🐛 (release-rw): Gate docs-build/docs-preview on intent.yaml artifacts.docs != skip #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08faf1d
🐛 (validation): Gate docs-build on intent.yaml `artifacts.docs != skip`
Chisanan232 May 26, 2026
744782c
🐛 (validation): Accept `skipped` as a pass for docs-build in validati…
Chisanan232 May 26, 2026
9a2a37a
🐛 (staging): Gate docs-preview + accept skipped in staging-summary
Chisanan232 May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/rw_release_staging_complete.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,10 @@ jobs:
docs-preview:
uses: ./.github/workflows/rw_docusaurus_operations.yaml
needs: [config, compute-version]
# Skip the Docusaurus preview deploy when intent.yaml sets
# `artifacts.docs: skip` — projects using MkDocs (or any non-Docusaurus
# docs system) have no `docs/package.json` to install from.
if: needs.config.outputs.docs != 'skip'
with:
package-name: ${{ inputs.package-name }}
operation: 'deploy-preview'
Expand Down Expand Up @@ -249,7 +253,7 @@ jobs:
# Validate results based on whether Docker processes were expected
VERSION_OK="${{ needs.compute-version.result == 'success' }}"
PYPI_OK="${{ needs.pypi-test.result == 'success' }}"
DOCS_OK="${{ needs.docs-preview.result == 'success' }}"
DOCS_OK="${{ needs.docs-preview.result == 'success' || needs.docs-preview.result == 'skipped' }}"

if [ "$HAS_DOCKERFILE" = "true" ]; then
# Docker processes should have run - validate them
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/rw_release_validation_complete.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,11 @@ jobs:
docs-build:
uses: ./.github/workflows/rw_docusaurus_operations.yaml
needs: [config, intent-parse]
# Skip the Docusaurus test invocation when intent.yaml sets
# `artifacts.docs: skip` — projects using MkDocs (or any non-Docusaurus
# docs system) declare this so the validation pipeline doesn't try to
# `pnpm install` in a Markdown-only `docs/` tree.
if: needs.intent-parse.outputs.docs != 'skip'
with:
package-name: ${{ inputs.package-name }}
operation: 'test'
Expand Down Expand Up @@ -216,7 +221,7 @@ jobs:
# Validate results based on whether Docker processes were expected
INTENT_OK="${{ needs.intent-parse.result == 'success' }}"
PYTHON_OK="${{ needs.python-build-check.result == 'success' }}"
DOCS_OK="${{ needs.docs-build.result == 'success' }}"
DOCS_OK="${{ needs.docs-build.result == 'success' || needs.docs-build.result == 'skipped' }}"

if [ "$HAS_DOCKERFILE" = "true" ]; then
# Docker processes should have run - validate them
Expand Down
Loading