Changes regarding sha verification#207
Conversation
Security Policy Alert: Secret Policy ViolationThis workflow run has been blocked by StepSecurity's secrets policy because it accesses secrets and the workflow file differs from the default branch. To approve this workflow, please add the Note: The label must be added by someone other than the PR author (cx-atish-jadhav) or automation bots to ensure proper security review. After the label is added, you can re-run the blocked workflow to proceed. This workflow will be automatically approved once merged into the default branch. For more information, see StepSecurity's Secret Exfiltration Policy documentation. |
Security Policy Alert: Secret Policy ViolationThis workflow run has been blocked by StepSecurity's secrets policy because it accesses secrets and the workflow file differs from the default branch. To approve this workflow, please add the Note: The label must be added by someone other than the PR author (cx-atish-jadhav) or automation bots to ensure proper security review. After the label is added, you can re-run the blocked workflow to proceed. This workflow will be automatically approved once merged into the default branch. For more information, see StepSecurity's Secret Exfiltration Policy documentation. |
| const trimmed = content.trim(); | ||
| if (trimmed) version = trimmed; | ||
| } catch { | ||
| // version file absent — fall through to defaults |
There was a problem hiding this comment.
Why we have empty catch block ?
| const content = await fsPromises.readFile(this.getChecksumsFilePath(), 'utf-8'); | ||
| checksum = (JSON.parse(content) as Record<string, string>)[key] ?? null; | ||
| if (checksum === null) { | ||
| logger.warn(`No checksum found for ${key} in checksums file. Download will not be verified.`); |
There was a problem hiding this comment.
we should throw an exception here. Valid checksum is not found.
| logger.warn(`No checksum found for ${key} in checksums file. Download will not be verified.`); | ||
| } | ||
| } catch { | ||
| logger.warn(`Checksums file not found. Download of version ${version} will not be verified.`); |
2 participants
No description provided.