Repository navigation
fix(clearance): confirm extension keepalive before observation - #202
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sw_keepalive_confirmedgate immediately afterextension_config_inject, before target navigationswKeepalivealarm exists usingchrome.alarms.get()sw_keepalive_alarm_present(bool/None) andsw_keepalive_alarm_error_type(str on failure)Motivation
Real smoke on v0.47.6 blocked at
clearance_observedwithextension_diagnostic: unavailable/no SW target found. TheswKeepalivealarm (added in v0.47.6) may not be created before observation begins. This gate surfaces that failure fast.Changes
infrastructure/browser/pydoll_engine.py—async read_extension_alarm(alarm_name)(CDP, argument as value — no injection risk; per-step timeout 2s)cli/real_clearance_composition.py—make_sw_keepalive_checker(engine, loop)factory (10s outer timeout)cli/smoke_clearance_real.py—GATE_SW_KEEPALIVE_CONFIRMEDgate (PASS/BLOCKED/unreachable paths)cli/main.py— factory wired intoharness.run()on--real-clearancepathTest plan
TestReadExtensionAlarm,TestMakeSwKeepaliveChecker,TestSwKeepaliveConfirmedGate)Closes #201