Conversation
There was a problem hiding this comment.
馃煛 Changes recommended
Concurrent type checks may exceed available host memory; resource or concurrency handling needs validation.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates six type-check scripts to use Node with an 8 GB heap limit, preventing TypeScript out-of-memory failures and improving Windows compatibility.
Changes:
- Replaces direct
tscinvocations with explicit Node commands. - Preserves
--noEmittype-check behavior.
File summaries
| File | Description |
|---|---|
packages/variables/package.json |
Raises type-check heap limit |
packages/business/package.json |
Raises type-check heap limit |
packages/automated-response/package.json |
Raises type-check heap limit |
packages/ai/package.json |
Raises type-check heap limit |
integrations/api/package.json |
Raises type-check heap limit |
apps/worker/package.json |
Raises type-check heap limit |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 1
- Review effort level: Lite
馃挕 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| }, | ||
| "scripts": { | ||
| "check-types": "tsc --noEmit", | ||
| "check-types": "node --max-old-space-size=8192 ../../node_modules/typescript/bin/tsc --noEmit", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1169.
Raises the Node heap limit for the six
check-typesscripts that can OOM when TypeScript loads the@chatbotx.io/businessdependency graph.The scripts now invoke TypeScript directly with:
This also avoids relying on POSIX-style inline
NODE_OPTIONSassignment, so the scripts work from Windows package execution as well.Validation
Reproduced the failure by limiting the outer Node heap to 2048 MB:
A direct
tsc --noEmitfor@chatbotx.io/businessfailed with:With the updated scripts, Turbo completed all six affected workspaces successfully under the same constrained environment:
Validated workspaces:
worker@chatbotx.io/ai@chatbotx.io/automated-response@chatbotx.io/business@chatbotx.io/variables@chatbotx.io/integration-apiAlso verified with
git diff --check.