Conversation
There was a problem hiding this comment.
馃煝 Approval recommended
No unresolved issues block approval.
Pull request overview
Fixes stale query parameters when switching channels on /channels/create.
Changes:
- Replaces existing
channelvalues safely. - Removes stale
errorparameters while preserving valid query state. - Adds regression tests for query handling.
File summaries
| File | Summary |
|---|---|
apps/builder/src/features/inboxes/components/inbox-select-card.tsx |
Normalizes channel-selection query parameters. |
apps/builder/__tests__/inbox-select-card.test.tsx |
Adds regression coverage for query behavior. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix channel selection on
/channels/createso switching channels does not carry stale query state into the next attempt.Previously, the picker appended a new
channelvalue to the entire existing query string. This could:errorinto a new channel attemptchannelparametersFix
InboxSelectCardnow updates the query throughURLSearchParams:errorchannelworkspaceIdTests
Added regression coverage for:
workspaceIderrorchannelchannelparameter existsgit diff --checkpasses.Focused Vitest execution could not complete locally because of Windows pnpm/environment issues, not a code-level test failure.
Fixes #1155