Fixes incompatibility with pip 20.1+ and adds some features#2
Open
MaliciousFiles wants to merge 11 commits into
Open
Fixes incompatibility with pip 20.1+ and adds some features#2MaliciousFiles wants to merge 11 commits into
MaliciousFiles wants to merge 11 commits into
Conversation
Adds a sound_path argument to show_toast and makes the default duration 0 because the toasts already last for 5 seconds on Windows.
Adds an argument to show_toast to customize the hover tooltip on the tray icon
Fixed parse_requirements because it was broken as of pip 20.1
MaliciousFiles
changed the title
changes the version in the setup to 0.93
I'm beginning to test (it's still commented out) changing the winreg to have a custom notification duration - how long it stays on screen.
Uses something else instead of dealing directly with winreg, and add more parameters to show_toast
We are using a different documentation
_uniqueid could be repeated so I switched to the UUID module
Raises exception so the user can catch them instead of just logging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been working on a new fork that adds some updated features. I am also looking to add the ability to have buttons to the notifications, however have not figured that out yet. For now I have only added custom sounds. I also fixed your setup.py which was broken as of pip 20.1. I have not added any dependencies, only used native libraries.