Skip to content

Remove stale upload_to_gcs call from /api/capture handler #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noahsprent merged 1 commit into from
Jun 3, 2026
Merged

Remove stale upload_to_gcs call from /api/capture handler #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 2 additions & 15 deletions pioreactor_camera/camera_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,23 +133,10 @@ def do_POST(self):
path = parsed.path.rstrip("/")

if path == "/api/capture":
from pioreactor_camera.camera_capture import capture_image, upload_to_gcs, IMAGE_DIR as CAP_DIR
from pioreactor_camera.camera_capture import capture_image, IMAGE_DIR as CAP_DIR
filename = capture_image(CAP_DIR)
if filename:
# Optionally upload to GCS
try:
upload_gcs = config.getboolean("camera_capture.config", "upload_to_gcs", fallback=True)
if upload_gcs:
gcs_bucket = config.get(
"camera_capture.config", "gcs_bucket",
fallback="gs://pioreactor-webcam-snaps-1768947561/webcam_snaps"
)
gcs_project = config.get(
"camera_capture.config", "gcs_project", fallback="changebio-tech"
)
upload_to_gcs(CAP_DIR / filename, gcs_bucket, gcs_project)
except Exception:
pass
# GCS upload handled by separate cron (~/take_and_upload_photo.sh)
ts = parse_image_timestamp(filename)
self._json_response({
"success": True,
Expand Down
Loading