fix(factory): wrap treasury init failures in TreasuryInitFailed - #8
Merged
Merged
Conversation
deploy_treasury called the new treasury's initialize directly, so a treasury failure (e.g. InvalidThreshold #8) propagated with the treasury's own error code. Treasury and factory codes overlap with different meanings, so clients could decode it as the wrong factory error. Call try_initialize and raise the new Error::TreasuryInitFailed = 5 on any failure (contract, auth or host error). The panic reverts the whole deploy, so no treasury or org record is left behind. Tests: threshold 3 with 2 approvers returns TreasuryInitFailed with org count 0; threshold 0 panics with Error(Contract, #5). Documented in the README error table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deploy_treasury called the new treasury's initialize directly, so a treasury failure (e.g. InvalidThreshold #8) propagated with the treasury's own error code. Treasury and factory codes overlap with different meanings, so clients could decode it as the wrong factory error.
Call try_initialize and raise the new Error::TreasuryInitFailed = 5 on any failure (contract, auth or host error). The panic reverts the whole deploy, so no treasury or org record is left behind.
Tests: threshold 3 with 2 approvers returns TreasuryInitFailed with org count 0; threshold 0 panics with Error(Contract, #5). Documented in the README error table.