-
Notifications
You must be signed in to change notification settings - Fork 9
EXT_textureInfo_constant_lod #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@markschlosseratbentley @pmconne This first draft is ready for review. Feedback especially needed on the implementation notes part and if the formula is explained accurately and clearly, and how many shader-specific details to include here. Questions for reviewers:
|
No, we agreed that this one is of potential general utility (we know of at least one other organization that has expressed interest in something similar), hence the |
danielzhong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Just some small suggestions.
|
|
||
| ## Overview | ||
|
|
||
| Constant level-of-detail ("LOD") is a technique of texture coordinate generation which dynamically calculates cordinates to keep the texture near a certain size on the screen, thus preserving the level of detail no matter what the zoom level. It blends from one size of the texture to another as the view is zoomed in or out so that the change is smooth. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cordinates → coordinates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
|
|
||
| ## Specifying Constant LOD Texture Mapping | ||
|
|
||
| The `EXT_textureInfo_constant_lod` extension is defined on `textureInfo` structures. When that `textureInfo` is used by a material, this extension applies the constant LOD technique to the specified texture. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job with this spec so far. As discussed earlier (with @pmconne), we could consider adding some more clear legalese in this section which makes it clear how these extension properties directly affect the on-screen appearance. For example: "when these properties are specified in a certain way, the following shows up on screen" (flesh that statement out).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the "Specifying Constant LOD Texture Mapping" section with an example json snippet and an explanation of what each property in the example extension means for the on-screen appearance. Let me know if this is what you meant, or if it should be more detailed.
I decided to keep the formulas in this latex format because it provides subscripts, superscripts, and the floor symbol which are useful in this context. It also is displayed correctly in the github markdown preview. Other extensions like the PBR glossiness formulas use a code-like style for formulas though, which I am also open to switching to.
...dor/EXT_textureInfo_constant_lod/schema/textureInfo.EXT_textureInfo_constant_lod.schema.json
Show resolved
Hide resolved
|
The specification should define what the TextureInfo's |
This PR is one result of splitting up #87 into more granular work.
This PR exists strictly for planning/feedback - this extension (EXT_textureInfo_constant_lod), once ready, should be submitted as a separate PR to KhronosGroup. This starts with Bentley's minimum requirements as a baseline.