refactor(v2): rename SensorSnapshot, move EMAFilter to util class#92
Merged
Conversation
Both NormalStage and EnergyStage carried the same `(prev*(den-1) + sample) / den` inline arithmetic. Lifted into `Filter::ema` so the call site reads its intent.
NormalStage and EnergyStage were each filtering vbus_mv and current_ma by hand. Folded the per-field EMA into a Filter::ema(LoadReading, ...) overload so both call sites read like single-shot smoothing. Rename frames the data as a load-side measurement, not a generic sensor blob.
kawinie
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rename
SensorSnapshottoLoadReading(the struct only carries vbus and current measured at the load) and adds aLoadReadingoverload toFilter::ema.NormalStageandEnergyStagewere each running(prev*(den-1) + sample) / denfor both fields. Now each stage callsFilter::ema(prev, sample, den)once.SensorEvent.snapshotbecomesSensorEvent.load.Linked issues
Hardware tested
How tested:
pio test -e native(130/130 passing).Breaking change / migration
Details:
Notes