feat(v2): blink V/A readout while output disabled#91
Merged
Conversation
kawinie
force-pushed
the
feat/v2-readout-blink
branch
from
f2587a7 to
df23a35
Compare
Half-period 500ms (1Hz cycle).
kawinie
force-pushed
the
feat/v2-readout-blink
branch
from
df23a35 to
be59dc3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously, there was no preview of the expected V/A at output terminal when the output is off. Sure, we can set target V and A of the PD sink but the real values could be way off depending on multiple factors including voltage drop across the wire.
This PR introduces blinking behavior to the live readouts in order to distinguish between "Preview" numbers and "read terminal measurements" when output is enabled.
NOTE: I have not enabled the reading from voltage divider yet in this PR
Linked issues
Hardware tested
How tested: native unit test added (
NormalView::ReadoutHiddenKeepsLabelsHidesValues). HW1_3 verification pending.Breaking change / migration
Details: V/A numeric values blink at 1 second period on the NORMAL stage while output is disabled. Steady once enabled.
Notes