refactor(v2): drop -dev, add HW envs, clean up headers#90
Merged
Conversation
- add envs support for HW1.0 and 1.1 - state.h folds into pocketpd.h and events.h - move v1 to src/v1/main.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restructures v2's compile-time hardware identity to support more board revisions. The single
HW1_3_V2board flag is replaced with aHW_VERSION_MAJOR/HW_VERSION_MINORpair so v2 source can branch on rev numerically (e.g.#if HW_VERSION_MAJOR == 1 && HW_VERSION_MINOR >= 3). Adds envs for HW1.0 and HW1.1, drops the-devversion tag from v2 envs.Details:
HW1_0(v1),HW1_0_V2,HW1_1_V2. v2 envs go from2.0.0-devto2.0.0.state.hdeleted.ButtonId/Gesturemove topocketpd.h,SensorSnapshottoevents.h.main.cppdrops the#ifdef HW1_3_V2fork. v1 entry now lives insrc/v1/main.cpp.Linked issues
Hardware tested
How tested: build-only refactor, no runtime change.
Breaking change / migration
Details:
Notes