-
Notifications
You must be signed in to change notification settings - Fork 25
Refactor header layout, fix weather data URLs, and update version #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
1210c55
feat: dash mantine table close #251
FedericoTartarini ddda809
refactor: update header layout and location string formatting close #250
FedericoTartarini b5f83b4
Bump version: 0.10.1 → 0.10.2
FedericoTartarini 1c7b240
test: update test load
FedericoTartarini bd05cd3
build: include tag
FedericoTartarini f6d26da
fix: refresh One Building weather data and fix broken URLs #272
t-kramer edbe62f
test: increase timeout for location info loading in summary tests
t-kramer 82920e5
fix: format for ruff
t-kramer ee1baaa
fix: add timeout to Köppen-Geiger climate zone API request
t-kramer 1d29fa8
fix: replace dead Köppen-Geiger API with kgcpy local lookup
t-kramer bc86cd4
fix: update humidity legend entry #271
t-kramer f444e3a
GITBOOK-55: No subject
t-kramer 5daa36b
Merge pull request #273 from CenterForTheBuiltEnvironment/fix/272-url…
FedericoTartarini ecfdc2a
fix: text formatting in Docs
t-kramer 0315539
fix: cast lat/lon to float before calling lookupCZ in summary
t-kramer 47966a6
fix: apply ruff formatting to summary.py
t-kramer 67beae0
merge: resolve one_building.csv conflict, keep refreshed data
t-kramer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| [bumpversion] | ||
| current_version = 0.10.1 | ||
| current_version = 0.10.2 | ||
| commit = True | ||
| tag = True | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -265,34 +265,23 @@ def switch_si_ip(_, si_ip_input, url_store, lines): | |
| ) | ||
| def enable_tabs_when_data_is_loaded(meta, data): | ||
| """Hide tabs when data are not loaded""" | ||
| default = "Current Location: N/A" | ||
| if data is None: | ||
| return ( | ||
| True, | ||
| True, | ||
| True, | ||
| True, | ||
| True, | ||
| True, | ||
| True, | ||
| True, | ||
| default, | ||
| ) | ||
| else: | ||
| return ( | ||
| False, | ||
| False, | ||
| False, | ||
| False, | ||
| False, | ||
| False, | ||
| False, | ||
| False, | ||
| "Current Location: " | ||
| + meta[Variables.CITY.col_name] | ||
| + ", " | ||
| + meta[Variables.COUNTRY.col_name], | ||
| ) | ||
| location_string = "Location: N/A" | ||
| disable_links = True | ||
| if data is not None: | ||
| location_string = f"Location: {meta[Variables.CITY.col_name]}, {meta[Variables.COUNTRY.col_name]}" | ||
| disable_links = False | ||
|
Comment on lines
+270
to
+272
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Guard
Proposed fix- if data is not None:
- location_string = f"Location: {meta[Variables.CITY.col_name]}, {meta[Variables.COUNTRY.col_name]}"
+ if (
+ data is not None
+ and meta is not None
+ and Variables.CITY.col_name in meta
+ and Variables.COUNTRY.col_name in meta
+ ):
+ location_string = (
+ f"Location: {meta[Variables.CITY.col_name]}, "
+ f"{meta[Variables.COUNTRY.col_name]}"
+ )
disable_links = False🤖 Prompt for AI Agents |
||
|
|
||
| return ( | ||
| disable_links, | ||
| disable_links, | ||
| disable_links, | ||
| disable_links, | ||
| disable_links, | ||
| disable_links, | ||
| disable_links, | ||
| disable_links, | ||
| location_string, | ||
| ) | ||
|
|
||
|
|
||
| @callback( | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove code fences around the
<figure>block.Wrapping the figure in fenced code makes it render as literal code instead of an image/figure block. Keep the HTML figure block unfenced.
Proposed fix
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)
[warning] 40-40: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🤖 Prompt for AI Agents