Disambiguate WithShawarma overloads#16
Merged
Merged
Conversation
Motivation ---------- The current overloads of WithShawarma leave ambiguity in overload resolution, in particular if you want to call with no parameters or with only an endpoint name. Modifications ------------- Add overloads and change defaults in a way that is both source and binary backward compatible. Also eliminate a minor heap allocation in the case where `autoStart` is passed as `false` by reusing the shared default options.
There was a problem hiding this comment.
Pull request overview
This PR updates the WithShawarma extension method overload set to avoid ambiguous overload resolution (notably for parameterless calls and calls specifying only an endpoint name) while keeping behavior source/binary compatible and reducing allocations in the common autoStart: false path.
Changes:
- Added overloads for
WithShawarma()/WithShawarma(bool autoStart)andWithShawarma(ShawarmaOptions? options)to make common call patterns unambiguous. - Adjusted the existing endpoint-based overload signatures to remove optional parameters that contributed to ambiguity.
- Reused
ShawarmaOptions.DefaultwhenautoStartisfalseto avoid allocating a new options instance.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JonathanAtCenterEdge
approved these changes
Mar 6, 2026
Collaborator
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The current overloads of WithShawarma leave ambiguity in overload resolution, in particular if you want to call with no parameters or with only an endpoint name.
Modifications
Add overloads and change defaults in a way that is both source and binary backward compatible. Also eliminate a minor heap allocation in the case where
autoStartis passed asfalseby reusing the shared default options.