Implement parallel network discovery - #28
Open
VictorLiwentao wants to merge 1 commit into
Open
VictorLiwentao wants to merge 1 commit into
VictorLiwentao wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #17.
Makes
n_jobsactually control parallel execution indiscover_network.The work is parallelized by target variable, with workers returning edges and the parent process building the graph.
Local benchmark on a MacBook Pro with M1 Pro (8 logical CPUs), macOS arm64; synthetic lag-1 Gaussian chain, T=500, max_lag=2, n_shuffles=50, median of 3 runs after warm-up:
n_jobs=1) → 2.51s (n_jobs=-1), ~4.0x speedupn_jobs=1) → 6.43s (n_jobs=-1), ~4.5x speedupSerial and parallel runs produced matching graphs.
40 discovery tests pass, and serial/parallel outputs match.