Support light/dark/system themes and remember user preference (#165)#208
Open
kyoungholee wants to merge 2 commits intoCefalo:developfrom
Open
Support light/dark/system themes and remember user preference (#165)#208kyoungholee wants to merge 2 commits intoCefalo:developfrom
kyoungholee wants to merge 2 commits intoCefalo:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
color-schemes.tswith a dedicateddarkpalette.ThemeModeContextto manage theme preference (light,dark,system) and resolve the actual mode.themeModekey.ThemeModeProviderso the resolved mode is applied globally.PreferenceViewto expose an Appearance section with a 3-way toggle and made styling use theme tokens instead of hard-coded colors where relevant.Behavior
prefers-color-schemesetting.Testing