Repository navigation
Vignettes and bugs - #27
Merged
Merged
Conversation
remlapmot
approved these changes
Dec 10, 2025
remlapmot
left a comment
remlapmot
left a comment
Contributor
There was a problem hiding this comment.
Great work.
I have made some small suggestions.
Yesterday when converting our short course practical to Python I was getting an error from _random_selection() - so I am hopeful you might have fixed what I was encountering (but I am new to Polars so it may just be I haven't quite converted my Stata dataset to the Polars DataFrame totally correctly). Will let you know.
| @@ -0,0 +1,181 @@ | |||
| # Exploring Results | |||
| ## SEQuential Analysis: {date}: censoring | |||
|
|
|||
Contributor
There was a problem hiding this comment.
For me it would be worth adding a python chunk here with the code that generated the results - because without that a user has a harder time using this vignette.
Co-authored-by: Tom Palmer <remlapmot@hotmail.com>
Co-authored-by: Tom Palmer <remlapmot@hotmail.com>
Co-authored-by: Tom Palmer <remlapmot@hotmail.com>
Co-authored-by: Tom Palmer <remlapmot@hotmail.com>
Co-authored-by: Tom Palmer <remlapmot@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some vignettes added as examples.
Also found some bugs in name collision within LTFU, bootstrapping, and random selection.