Repository navigation
Add unstabilized treatment weights and improve memory footprint of bootstrapping - #175
Merged
Merged
Conversation
Collaborator
Author
|
The check failures are to do with some |
ryan-odea
approved these changes
Oct 27, 2026
ryan-odea
left a comment
Collaborator
There was a problem hiding this comment.
Looks good Tom! Thanks for catching the bootstrap memory footprint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paul found that he needed unstabilized treatment weights in his analysis for a comparison - so I guess we may as well add it?
Adds
weight.stabilizedtoSEQopts()(defaultTRUE, unchanged behaviour). Withweight.stabilized = FALSEno numerator models are fit, so the treatment weights are cumulative products of 1 / denominator; LTFU and visit weights keep their numerators.Also corrects the
selection.random/selection.probdocumentation (which I can send as a separate PR if you don't want the unstab weights added).And improves memory footprint of bootstrapping - was collecting
nwhich wasn't used.small amends to justfile