Skip to content

Add unstabilized treatment weights and improve memory footprint of bootstrapping - #175

Merged
remlapmot merged 10 commits into
mainfrom
devel-2026-10-12
Oct 27, 2026
Merged

remlapmot merged 10 commits into
mainfrom
devel-2026-10-12

Conversation

@remlapmot

@remlapmot remlapmot commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator
  • Paul found that he needed unstabilized treatment weights in his analysis for a comparison - so I guess we may as well add it?

    Adds weight.stabilized to SEQopts() (default TRUE, unchanged behaviour). With weight.stabilized = FALSE no numerator models are fit, so the treatment weights are cumulative products of 1 / denominator; LTFU and visit weights keep their numerators.

  • Also corrects the selection.random / selection.prob documentation (which I can send as a separate PR if you don't want the unstab weights added).

  • And improves memory footprint of bootstrapping - was collecting n which wasn't used.

  • small amends to justfile

@remlapmot
remlapmot requested a review from ryan-odea October 26, 2026 11:31
@remlapmot

remlapmot commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator Author

The check failures are to do with some internet access/CRAN/ Posit PPM issue, R CMD check passes fine locally:

   Status: OK

── R CMD check results ──────────────────────────────────────────────────── SEQTaRget 1.4.5.9000 ────
Duration: 3m 26.6s

0 errors ✔ | 0 warnings ✔ | 0 notes ✔

@remlapmot remlapmot changed the title Add unstabilized treatment weights Add unstabilized treatment weights and improve memory footprint of bootstrapping Oct 26, 2026

@ryan-odea ryan-odea left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Tom! Thanks for catching the bootstrap memory footprint.

@remlapmot
remlapmot merged commit 64678cb into main Oct 27, 2026
7 checks passed
@remlapmot
remlapmot deleted the devel-2026-10-12 branch October 27, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants