Add Clear button to Clipboard tool(PAINTROID-802) #1359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added Clear button to clipboard tool UI with delete icon - Implemented clearClicked() callback to clear clipboard content - Added enableClear() method to control button state - Clear button is disabled initially, enabled after Copy/Cut - Clicking Clear provides visual feedback via highlightBox() - Added unit tests for Clear button functionality - Fixes issue where users couldn't clear clipboard without switching tools
gurnoorpannu
changed the title
- Made clearChip property nullable (Chip?) - Added null-safe calls when accessing clearChip - This prevents potential issues when the view is not found - Fixes SprayTool transparency test failure
Root cause: Calling enableClear(false) in DefaultClipboardToolOptionsView init block was mutating tool state during construction, causing ToolOptionsViewController to trigger fallback logic to ShapeTool. Solution: - Removed enableClear(false) from DefaultClipboardToolOptionsView init - Added enableClear(false) to ClipboardTool init after callback setup - This matches the lifecycle pattern and prevents state mutation during view construction Fixes: - ClipboardToolIntegrationTest.testBorders - ClipboardToolTest.testClear* tests - LandscapeIntegrationTest.* - LayerIntegrationTest.* - TemporaryFileSavingTest.*
Making clearChip nullable was masking potential initialization issues. Since action_clear is always present in the layout, findViewById should never return null. This matches the pattern used for other chips and ensures proper initialization.
Calling enableClear(false) during tool initialization was causing shared state corruption that prevented SprayTool from drawing. Clear button state will be managed through user interactions only.
Added isDisplayed() checks before clicking shape buttons to prevent NoMatchingViewException when ShapeTool options view is not yet visible. This ensures Espresso waits for the UI to be ready before attempting interactions, fixing testShapeToolBoxGetsPlacedCorrectWhenZoomedIn. Changes: - performSelectShape: Added visibility check before click - performSelectShapeDrawType: Added visibility check before click Fixes ShapeToolIntegrationTest.testShapeToolBoxGetsPlacedCorrectWhenZoomedIn
Added allowEmptyArchive: true to all archiveArtifacts calls to prevent build failure when coverage artifacts or logs are missing. This ensures Jenkins exits cleanly (exit code 0) when tests pass but optional artifacts are not generated. Changes: - Debug APK archiving: Added allowEmptyArchive - Catroid AAR archiving: Added allowEmptyArchive - Catroid APK archiving: Added allowEmptyArchive - logcat.txt archiving: Added allowEmptyArchive Fixes Jenkins artifact archiving step failure.
Author
|
@juliajulie95 @csongorhg |
Contributor
|
@gurnoorpannu thanks for the heads-up, FYI at the moment Jenkins is being worked on, due to some workarounds needed due to a recent maintenance. I will check via this PR again as soon as I am done with that. |
Author
|
@csongorhg oh! okay np👍 |
Author
|
@csongorhg any update? can you tell like from when we can start contributing again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior:-
there is NO WAY to clear this stored clipboard data!
Once you copy/cut something:
Changes:-
Before in dialog_pocketpaint_clipboard_tool.xml, the tool currently had only 3 buttons:
Added a 4th button - a "Clear" button that will:
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.