Repository navigation
One atomic write helper for checkpoints and the dataset cache - #81
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
serialize::atomic::write_atomicis the only atomic write now. It gains what the copy inmnist.rshad: a per-call counter in the temp name next to the pid, and cleanup of the temp file on any failure, the rename included.write_atomic_bytescovers callers with the bytes in memory, andmnist.rsuses it instead of its own helper. The helper's tests move intoatomic.rsand now cover the two error paths: a write that fails midway leaves the old file byte-identical and no temp behind, and a failed rename leaves no temp. Intests/robustness.rsthe two "does not destroy the good copy" tests are renamed to what they check, saving over a corrupt file, the test that asserted the temp is absent after a successful save is gone since the rename guarantees that, and the section divider is gone. The two identical doc paragraphs on the savers are one line each.Why
#72 and #74 each added an atomic write, in different modules with different gaps. One helper, with both sets of behaviour and tests for the paths that matter, is what the reviews on both asked for.
How it was verified
cargo testpassescargo clippy --all-targets -- -D warningsis cleancuda_parityon a GPU--releasecargo docwith-D warningsis clean. No CUDA code touched.Checklist
tensor/opsandautograd/opsstill mirror each other///docs