Repository navigation
Reject zero-length sequences in LSTM/GRU with a clear message - #78
Merged
Merged
Conversation
CanReader
force-pushed
the
fix/zero-length-seq-27
branch
from
November 12, 2026 08:47
92f427e to
cedef5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
steps > 0incheck_sequenceso a zero-length sequence panics with a message naming the layer and shape, instead of propagating tocat: needs at least one tensorstack: needs at least one tensorassert inTensor::stackso an empty stack also has its own message#[should_panic]tests for LSTM, GRU with[1, 0, 2]input, and forTensor::stack(&[], 0)All 41 existing tests pass.
Closes #27