Remove spread operators in DisallowMethodCallOnUnsafeDataObjectRule

.changeset/twenty-spies-eat.md

@@ -0,0 +1,5 @@
+---
+"@cambis/silverstan": patch
+---
+
+Remove spread operators from DisallowMethodCallOnUnsafeDataObjectRule.

.husky/pre-commit

@@ -1,4 +1,2 @@
 #!/usr/bin/env sh
 . "$(dirname -- "$0")/_/husky.sh"
-
-npx lint-staged

composer.json

@@ -29,7 +29,7 @@
         "phpstan/phpstan-phpunit": "^2.0",
         "phpstan/phpstan-strict-rules": "^2.0",
         "phpunit/phpunit": "^9.6",
-        "rector/rector": "2.2.4",
+        "rector/rector": "^2.3",
         "shipmonk/composer-dependency-analyser": "^1.7",
         "silverstripe/assets": "^2.3",
         "silverstripe/cms": "^5.2",

ecs.php

@@ -2,6 +2,7 @@
 
 declare(strict_types=1);
 
+use PhpCsFixer\Fixer\Import\OrderedImportsFixer;
 use PhpCsFixer\Fixer\Operator\NewWithParenthesesFixer;
 use PhpCsFixer\Fixer\Operator\NotOperatorWithSuccessorSpaceFixer;
 use SlevomatCodingStandard\Sniffs\Namespaces\ReferenceUsedNamesOnlySniff;
@@ -26,6 +27,16 @@
             'allowFallbackGlobalConstants' => false,
         ]
     )
+    ->withConfiguredRule(
+        OrderedImportsFixer::class,
+        [
+            'imports_order' => [
+                'class',
+                'function',
+                'const',
+            ],
+        ]
+    )
     ->withPreparedSets(
         common: true,
         psr12: true,

lint-staged.config.js

@@ -1,11 +1,12 @@
 /** @type {import('lint-staged').Config} */
 module.exports = {
-  '*.php': [
-    'php vendor/bin/parallel-lint --colors --blame',
-    'php vendor/bin/rector process --ansi',
-    'php vendor/bin/ecs check --fix --ansi',
+  '*.php': (filenames) => [
+    `php vendor/bin/parallel-lint src tests --colors --blame ${filenames.join(' ')}`,
+    `php vendor/bin/rector process --dry-run --ansi ${filenames.join(' ')}`,
+    `php vendor/bin/ecs check --fix --ansi ${filenames.join(' ')}`,
+    'php vendor/bin/phpstan analyse --ansi --memory-limit=-1',
   ],
   '!(e2e/*/composer.json)composer.json': [
-    'composer normalize --ansi'
+    'composer normalize --ansi',
   ],
 };

src/Rule/MethodCall/DisallowMethodCallOnUnsafeDataObjectRule.php

@@ -6,9 +6,6 @@
 
 use Cambis\Silverstan\Normaliser\Normaliser;
 use Cambis\Silverstan\Type\ObjectType\UnsafeObjectType;
-use Cambis\Silverstan\Type\TypeSpecifyingExtension\DataObjectDeleteTypeSpecifyingExtension;
-use Cambis\Silverstan\Type\TypeSpecifyingExtension\DataObjectExistsTypeSpecifyingExtension;
-use Cambis\Silverstan\Type\TypeSpecifyingExtension\DataObjectWriteTypeSpecifyingExtension;
 use Cambis\Silverstan\ValueObject\ClassAllowedMethodCall;
 use Override;
 use PhpParser\Node;
@@ -35,9 +32,12 @@
      * @var string[]
      */
     private const DEFAULT_ALLOWED_METHODS_CALLS = [
-        ...DataObjectDeleteTypeSpecifyingExtension::SUPPORTED_METHODS,
-        ...DataObjectExistsTypeSpecifyingExtension::SUPPORTED_METHODS,
-        ...DataObjectWriteTypeSpecifyingExtension::SUPPORTED_METHODS,
+        'delete',
+        'exists',
+        'isInDB',
+        'publishRecursive',
+        'publishSingle',
+        'write',
     ];
 
     /**

src/Type/TypeSpecifyingExtension/DataObjectDeleteTypeSpecifyingExtension.php

@@ -25,6 +25,7 @@ final class DataObjectDeleteTypeSpecifyingExtension implements MethodTypeSpecify
 {
     /**
      * @var string[]
+     * @api
      */
     public const SUPPORTED_METHODS = [
         'delete',

src/Type/TypeSpecifyingExtension/DataObjectExistsTypeSpecifyingExtension.php

@@ -25,6 +25,7 @@ final class DataObjectExistsTypeSpecifyingExtension implements MethodTypeSpecify
 {
     /**
      * @var string[]
+     * @api
      */
     public const SUPPORTED_METHODS = [
         'exists',

src/Type/TypeSpecifyingExtension/DataObjectWriteTypeSpecifyingExtension.php

@@ -25,6 +25,7 @@ final class DataObjectWriteTypeSpecifyingExtension implements MethodTypeSpecifyi
 {
     /**
      * @var string[]
+     * @api
      */
     public const SUPPORTED_METHODS = [
         'publishRecursive',