Fix SQL injection: validate query tables against TAP_SCHEMA whitelist#12
Open
Fix SQL injection: validate query tables against TAP_SCHEMA whitelist#12
Conversation
nexsciTAP never validated that tables in ADQL queries were registered in TAP_SCHEMA.tables, allowing access to system catalogs, cross-schema tables with PII, and database internals. This adds table validation at three layers (tap.py primary gate, runquery.py and propfilter.py defense-in-depth) and fixes a string-concatenation SQL injection in datadictionary.py with parameterized queries. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move table validation to runquery.py and propfilter.py only, where DB connections already exist. This eliminates one extra connection per request, which matters especially for Oracle where connection setup can take 50-200ms. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sqlparse tokenizes 'ORDER BY' as a single compound keyword, but extract_from_part only checked for 'ORDER' as a separate token. This caused columns in ORDER BY clauses to be extracted as table names, which the table validator then rejected as unauthorized. Also adds 'LIMIT' and 'OFFSET' as stop-keywords for completeness. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nexsciTAP never validated that tables in ADQL queries were registered in TAP_SCHEMA.tables, allowing access to system catalogs, cross-schema tables with PII, and database internals. This adds table validation in tapquery.py and propfilter.py (the two query execution paths) and fixes a string-concatenation SQL injection in datadictionary.py with parameterized queries.