Conversation
Changes done: - Extend `InputReqs` with `signerIndex4` field (next to `signerIndex`) - Extend `Cets` with `signerIndex4` field (next to `signerIndex`) - Read them from the Json version, if missing, fallback to default 0 - Extend `signHashEcdsa()` with extra `int signerIndex4` parameter - Extend `createCetAdaptorSigs()` with extra `int signingKeyIndex4` parameter - Extend `signTransaction()`with extra `int keyIndex4` parameter - Pass the extra parameters, down to the crytlib library methods.
This was referenced Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16 and #2 .
Use cryptlib from external common repository (see #17 ).
Changes for index4:
InputReqswithsignerIndex4field (next tosignerIndex)CetswithsignerIndex4field (next tosignerIndex)signHashEcdsa()with extraint signerIndex4parametercreateCetAdaptorSigs()with extraint signingKeyIndex4parametersignTransaction()with extraint keyIndex4parameterNote: The index4 change is untested!
See also:
v1.0.3: [Draft] Add new cryptlib and support index4 parameters #19v1.0.3: [Draft] Use cryptlib from external common repository #18cryptlib2[Draft] Add support for new index4 parameters #20