Fix parametricCurve helix approximation - #2094
Open
ASP-SuperExplorer wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2084.
parametricCurvecurrently defaults to variational smoothing, which can badly distort some curves. In the reported case, a 4-turn helix collapses even though the same curve with a non-integerstoplooks fine.This PR changes the default
smoothingvalue forWorkplane.parametricCurvetoNone, matching the behavior that preserves the sampled helix shape. It also adds a regression test forstop=4that checks the sampled radius stays close to 1.Tested with: