Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new thermald hardware profile intended to enable Intel’s Thermal Daemon on supported mobile hybrid Intel CPUs (aligned with the existing intel-lpmd targeting).
Changes:
- Add a new
[thermald]profile with CPU/chassis filters for mobile systems. - Enable
thermald.serviceon install and disable it on remove via profile hooks.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+18
to
+30
| desc = 'Intel Thermal Daemon for supported mobile hybrid Intel CPUs' | ||
| class_ids = "0600" | ||
| vendor_ids = "8086" | ||
| device_ids = "*" | ||
| cpu_family = "6" | ||
| cpu_models = "151 154 183 186 191 170 172 189 204" | ||
| chassis_types = "8 9 10 11" | ||
| priority = 4 | ||
| packages = 'thermald' | ||
| post_install = """ | ||
| systemctl enable --now thermald.service | ||
| """ | ||
| post_remove = """ |
Comment on lines
+27
to
+32
| post_install = """ | ||
| systemctl enable --now thermald.service | ||
| """ | ||
| post_remove = """ | ||
| systemctl disable thermald.service | ||
| """ |
Member
Author
|
Lets do only via wiki, since some vendors expose wrong TDPs, which result into issue.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ventureoo You wrote in the intel-lpmd ticket that this could be also used for thermald.
Ive looked a bit into thermald and it seems reasonable to be enabled. It uses around 10-14MB memory.
Its only enabled for now for devices, which do also support intel-lpmd. This could be enhanced.