fix(dev): rebuild audify for Electron on npm install - #617
Merged
Merged
Conversation
Source installs often left audify without a native binary, so loopback-helper returned non-JSON stdout and Admin showed INVALID_HELPER_OUTPUT. Add @electron/rebuild, postinstall + rebuild:audio script, and short README notes.
Owner
Author
|
Linux box verification — 2026-09-26 (Europe/Istanbul) Commands / results:
Full |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm installsource checkout,audify.nodewas often missing → audio helper non-JSON stdout →INVALID_HELPER_OUTPUT.@electron/rebuild,postinstall/npm run rebuild:audio(scripts/rebuild-audify.js), and README notes (TR/EN).rebuild:audio/check:runtime.Test plan
Linux box verification (2026-09-26)
node --check scripts/rebuild-audify.js(exit 0)npm run rebuild:audio/node scripts/rebuild-audify.jsproducesnode_modules/audify/build/Release/audify.node(exit 0)/tmp/sv-fresh-test):npm installthennpm run check:runtimeexit 0 — native module loads; device list empty OK on this boxxvfb-run npm start(~45s): log shows[loopback] NO-DEVICE, noINVALID_HELPER_OUTPUTbanner/crash (killed after timeout; no interactive click-through)