Skip to content

fix: 릴리즈 리뷰 반영 (하루 넘는 리드타임을 미래 날짜에도 적용) - #211

Merged
chanwoo7 merged 1 commit into
developfrom
fix/release-review-multiday-lead-time
Aug 24, 2026
Merged

fix: 릴리즈 리뷰 반영 (하루 넘는 리드타임을 미래 날짜에도 적용)#211
chanwoo7 merged 1 commit into
developfrom
fix/release-review-multiday-lead-time

Conversation

@chanwoo7

Copy link
Copy Markdown
Member

배경

릴리즈 PR #209의 Codex 지적 반영입니다.
리드타임 컷오프를 당일(isToday)에만 적용해서, 판매자 설정 리드타임이 하루를 넘으면(설정 상한 7일) 미래 날짜에서 완전히 무시됐습니다.
예: 7일 리드타임 매장의 내일 슬롯이 달력·슬롯 조회에서 가용으로 보이고 createOrder도 통과했습니다(상품 제작 소요시간이 더 짧은 경우).

변경점

  • buildDaySlots의 컷오프를 절대 시각(now + 리드타임) 기준으로 변경.
    해당 날짜 자정 대비 현재 경과 분이 미래일에는 음수가 되어 컷오프가 자연스럽게 이월됩니다.
  • 달력 판정(evaluateDay)도 동일 규칙 적용 — 리드타임에 완전히 덮인 미래일은 CLOSED.
  • storePickupCalendar / storePickupTimeSlots / isPickupSlotAvailable(주문 생성 재검증) 세 경로가 모두 같은 컷오프를 공유합니다.

검증

  • real DB 회귀 테스트 1건 추가(3일 리드타임: 슬롯 판정·달력·시간 슬롯 3면 검증).
  • store pickup·order 스위트 86건 전체 통과.

릴리즈 PR #209 Codex 지적 반영. 리드타임 컷오프를 당일(isToday)에만
적용해, 판매자 설정 리드타임이 하루를 넘으면(최대 7일) 미래 날짜에서
무시됐다 — 7일 리드타임 매장의 내일 슬롯이 예약 가능으로 보이고
createOrder도 통과하는 문제.

- buildDaySlots 컷오프를 절대 시각(now + 리드타임) 기준으로 변경
  (해당 날짜 자정 대비 경과 분이 미래일에 음수가 되어 자연 반영)
- 달력 판정도 동일 규칙: 리드타임에 완전히 덮인 미래일은 CLOSED
- 회귀 테스트 1건 추가 (3일 리드: 슬롯 판정·달력·시간 슬롯 3면 검증)
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 87cd494f-5ad2-434a-a740-bb85635b2fc6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

🧹 knip — dead-code 리포트

요약 항목 없음
전체 리포트
(knip 출력 없음 — 이슈 0이거나 실행 실패)

청소 후보(오탐 가능) · 기준 docs/guide/architecture-conventions.md

@github-actions

Copy link
Copy Markdown

🩺 NestJS Doctor — 89/100 (Good)

진단 282건 (error 0).

Category error warning info
architecture 0 0 13
correctness 0 129 0
performance 0 24 17
schema 0 0 86
security 0 13 0
architecture / security 상위 항목
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal type 'IAuditLogRepository'.
  • warning security/security/no-exposed-env-vars: Direct 'process.env.NODE_ENV' access in 'AuthController'. Use ConfigService instead.
  • warning security/security/require-guards-on-endpoints: Endpoint 'start' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'callback' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'refresh' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'logout' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerLogin' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerRefresh' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerLogout' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'devIssueToken' has no @UseGuards() at class or method level.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal module '@/features/conversation/repositories/conversation.repository'.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal type 'ConversationRepository'.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal module '@/features/order/repositories/order.repository'.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal type 'OrderRepository'.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal module '@/features/product/repositories/product.repository'.

오탐 포함 가능 · 기준 docs/guide/architecture-conventions.md

@codecov

codecov Bot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions

Copy link
Copy Markdown

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 97.61% 4945/5066
🟢 Branches 93.99% 2016/2145
🟢 Functions 96.08% 955/994
🟢 Lines 98.21% 4500/4582

Test suite run success

1603 tests passing in 187 suites.

Report generated by 🧪jest coverage report action from 8211999

@chanwoo7
chanwoo7 merged commit 9181128 into develop Aug 24, 2026
12 checks passed
@chanwoo7
chanwoo7 deleted the fix/release-review-multiday-lead-time branch August 24, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant