Skip to content

fix: 릴리즈 리뷰 반영 (설명/이미지 필수 옵션 선택 시 주문 거절) - #210

Merged
chanwoo7 merged 1 commit into
developfrom
fix/release-review-checkout-option-customization
Aug 24, 2026
Merged

fix: 릴리즈 리뷰 반영 (설명/이미지 필수 옵션 선택 시 주문 거절)#210
chanwoo7 merged 1 commit into
developfrom
fix/release-review-checkout-option-customization

Conversation

@chanwoo7

Copy link
Copy Markdown
Member

배경

릴리즈 PR #209의 Codex 지적 반영입니다.
option_requires_description/option_requires_image가 켜진 옵션 그룹은 판매자가 요구한 커스텀 정보(문구·이미지)가 있어야 주문이 완성되는데, 체크아웃이 이 플래그를 읽지 않아 스냅샷만으로 SUBMITTED가 될 수 있었습니다.

변경점

  • findProductDetailById에 두 플래그 로드 추가.
  • 해당 그룹의 옵션을 선택한 주문은 커스텀 체크아웃 확장 전까지 거절(OPTION_CUSTOMIZATION_REQUIRED).
    그룹을 선택하지 않으면 기존대로 허용됩니다.
  • 커스텀 입력 확장 시 이 가드를 실제 커스텀 데이터 검증으로 대체합니다(후속 이슈에 포함).

검증

  • real DB 회귀 테스트 1건 추가(플래그 그룹 선택 거절/미선택 허용), 스위트 15건 통과.

릴리즈 PR #209 Codex 지적 반영. option_requires_description/image가
켜진 옵션 그룹은 판매자가 요구한 커스텀 정보 없이는 주문이 완성되지
않는데, 체크아웃이 플래그를 읽지 않아 스냅샷만으로 SUBMITTED가 됐다.

- findProductDetailById에 두 플래그 로드 추가
- 해당 그룹 옵션을 선택한 주문은 커스텀 체크아웃 확장 전까지 거절
  (미선택이면 기존대로 허용)
- 회귀 테스트 1건 추가
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e9e82e23-9c92-4bf4-8a6b-e61250ebd09e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

🧹 knip — dead-code 리포트

요약 항목 없음
전체 리포트
(knip 출력 없음 — 이슈 0이거나 실행 실패)

청소 후보(오탐 가능) · 기준 docs/guide/architecture-conventions.md

@github-actions

Copy link
Copy Markdown

🩺 NestJS Doctor — 89/100 (Good)

진단 282건 (error 0).

Category error warning info
architecture 0 0 13
correctness 0 129 0
performance 0 24 17
schema 0 0 86
security 0 13 0
architecture / security 상위 항목
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal type 'IAuditLogRepository'.
  • warning security/security/no-exposed-env-vars: Direct 'process.env.NODE_ENV' access in 'AuthController'. Use ConfigService instead.
  • warning security/security/require-guards-on-endpoints: Endpoint 'start' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'callback' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'refresh' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'logout' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerLogin' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerRefresh' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerLogout' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'devIssueToken' has no @UseGuards() at class or method level.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal module '@/features/conversation/repositories/conversation.repository'.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal type 'ConversationRepository'.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal module '@/features/order/repositories/order.repository'.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal type 'OrderRepository'.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal module '@/features/product/repositories/product.repository'.

오탐 포함 가능 · 기준 docs/guide/architecture-conventions.md

@github-actions

Copy link
Copy Markdown

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 97.61% 4949/5070
🟢 Branches 93.96% 2023/2153
🟢 Functions 96.08% 955/994
🟢 Lines 98.21% 4504/4586

Test suite run success

1602 tests passing in 187 suites.

Report generated by 🧪jest coverage report action from 1f4be4c

@codecov

codecov Bot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@chanwoo7
chanwoo7 merged commit 2acfcc6 into develop Aug 24, 2026
12 checks passed
@chanwoo7
chanwoo7 deleted the fix/release-review-checkout-option-customization branch August 24, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant