fix: normalize object properties in ConvertTo-ClikaeJsonArray for PS … - #32
Open
chodaict wants to merge 1 commit into
Open
fix: normalize object properties in ConvertTo-ClikaeJsonArray for PS …#32chodaict wants to merge 1 commit into
chodaict wants to merge 1 commit into
Conversation
…5.1 compatibility Fixes PowerShell 5.1 Pester test failures in Get-ClikaeProfile -Json. PS 5.1's ConvertTo-Json exhibits inconsistent behavior when serializing objects created from ordered hashtables, particularly when those objects have multiple properties. Under .NET Framework, property enumeration can become incomplete or reordered. Solution: Use Select-Object * to normalize the PSCustomObject before serialization. This forces re-enumeration of all properties consistently across PS 5.1 (.NET Framework) and PS 7+ (.NET Core). Resolves #31: "PowerShell module: Get-ClikaeProfile -Json fails Pester on Windows PowerShell 5.1 (passes on pwsh 7)"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…5.1 compatibility
Fixes PowerShell 5.1 Pester test failures in Get-ClikaeProfile -Json.
PS 5.1's ConvertTo-Json exhibits inconsistent behavior when serializing objects created from ordered hashtables, particularly when those objects have multiple properties. Under .NET Framework, property enumeration can become incomplete or reordered.
Solution: Use Select-Object * to normalize the PSCustomObject before serialization. This forces re-enumeration of all properties consistently across PS 5.1 (.NET Framework) and PS 7+ (.NET Core).
Resolves #31: "PowerShell module: Get-ClikaeProfile -Json fails Pester on Windows PowerShell 5.1 (passes on pwsh 7)"
What & why
Checklist
scripts/test.sh, annpm/maketarget) and they're green