Skip to content

Fix: prevent undisplayable videos from shutting own video sections #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anirvan wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: prevent undisplayable videos from shutting own video sections #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d19cb00
Fix UCSF featured videos JSON payload escaping in profile page script
anirvan Jun 15, 2026
67b17eb
prevent undisplayable videos from shutting own video sections
anirvan Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...ceCode/Profiles/Profiles/Profile/Modules/CustomViewUCSFPlugins/UCSFFeaturedVideos.ascx.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
using Profiles.Framework.Utilities;
using System.Xml;
using System.Collections.Generic;
using System.Web;
using System.Web.UI.HtmlControls;

namespace Profiles.Profile.Modules.CustomViewUCSFPlugins
Expand Down Expand Up @@ -42,7 +43,7 @@ private void LoadAssets()
//litjs.Text = base.SocialMediaInit(this.PlugInName);
//TODO Obviously change this
//litjs.Text = base.jsStart + "FeaturedVideos.init('" + Profiles.Framework.Utilities.GenericRDFDataIO.GetSocialMediaPlugInData(this.SubjectID, "UCSFFeaturedVideos").Replace("'", "\\'") + "'); " + base.jsEnd;
litjs.Text = base.jsStart + "FeaturedVideos.init('" + Profiles.Framework.Utilities.GenericRDFDataIO.GetSocialMediaPlugInData(this.SubjectID, "UCSFFeaturedVideos").Replace("\\", "\\\\").Replace("'", "\\'") + "'); " + base.jsEnd;
litjs.Text = base.jsStart + "FeaturedVideos.init('" + HttpUtility.JavaScriptStringEncode(Profiles.Framework.Utilities.GenericRDFDataIO.GetSocialMediaPlugInData(this.SubjectID, "UCSFFeaturedVideos")) + "'); " + base.jsEnd;


HtmlLink Displaycss = new HtmlLink();
Expand All @@ -55,4 +56,4 @@ private void LoadAssets()
}

}
}
}
2 changes: 1 addition & 1 deletion .../SourceCode/Profiles/Profiles/Profile/Modules/CustomViewUCSFPlugins/UCSFFeaturedVideos.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ FeaturedVideos.getVideoMetadata = function (video, max_height, max_width, callba
var oembedURL = oEmbedURLBase + '?maxheight=' + max_height + '&maxwidth=' + max_width + '&url=' + encodeURIComponent(video.url);
var req = $.ajax({
url: oembedURL,
dataType: "jsonp",
dataType: "json",
timeout: 10000,
success: callback
});
Expand Down