Link the approver's own page from the README's MCP row - #221
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe README documentation table now links to the “Approve from your assistant” workflow in the “Agents and MCP” row. ChangesDocumentation update
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other Merge Risk: ⚪ Minimal · up to The change only adds an approval workflow link to the README and is mergeable. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: arpan <contact@arpanghoshal.com>
arpanghoshal
force-pushed
the
readme-link-approver-page
branch
from
September 15, 2026 18:49
29ca854 to
87bc677
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One link. The
Agents and MCProw of the documentation table lists MCP overview and The gateway in five minutes, and omits Approve from your assistant, which is the page telling the person who has to answer how to do it without a checkout.Why this one is worth a PR
The README sells the approve decision harder than anything else in it. The demo turns on it, and the three-step walkthrough stops a €5,000 refund and waits for a person. Then the only way it ever shows a human answering is
ctrlrun approveat a shell.A reader evaluating this for a team asks whether their finance person needs a terminal and a checkout. The honest answer is no: there is a webhook, there are framework interrupts, and since
SPEC-mcp-operatorthere is a server with eight tools. The README cannot currently tell them any of that.ctrlrun mcp-operatorappears in this file exactly once, inside themcp-name:comment added for the registry, which is to say not at all.What it is not
Not a new section, and not a row in Three ways to use it. That table is the enforcement path, and
§1.1is emphatic that the two never meet: "ctrlrun gatewayis in the agent's path; this is in the approver's path, and the two never meet." A fourth row there would blur a distinction the spec works to keep. The documentation table is where a reader already goes looking for the next page, so the gap belongs to it.The link points at
docs.ctrlrun.devrather than the site, which is the ruletest_readme_assets.pystates for every documentation link in this file. Both URLs were checked live and return 200.Checks
scripts/check.sh: ruff format, ruff check, mypy --strict, 4128 passed, 317 skipped. Header copy pins and the badge row are untouched.Summary by CodeRabbit