0.12.1: the verify fixes 0.12.0 was tagged just before - #214
Conversation
`v0.12.0` was cut at the release merge and #213 landed on `main` shortly after, so the published wheel carried none of the three fixes. On the document that found them, a support agent with a grant of twelve refunds an hour, 0.12.0 grades 1 of 1 and calls thirty-one not applicable; this grades 22 of 22. Nothing here touches the enforcement path. The whole of it is `verify/scenarios.py`, the self-check tool, and it under-reported rather than over-claimed, which is the safe direction. It was severe enough to read as a tool that checks nothing. No adapter work: 1.3.0 already declares `ctrlrun>=0.5,<0.13`, so 0.12.1 is inside the range both published adapters accept. Also removed: `adopt-site/`, two files of empty Vite dependency cache swept into the repository root by #138 and referenced by nothing since. It shipped in no distribution, but it is the root a reader lands on. `.vite/` and `node_modules/` are now ignored so it cannot come back. Signed-off-by: arpan <contact@arpanghoshal.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (6)
💤 Files with no reviewable changes (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe project version and citation change to 0.12.1. The changelog adds release notes and documents verification corrections and cache cleanup. Committed Vite cache files are removed, and generated site-tooling caches are ignored. ChangesRelease and cache updates
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to This release is ready to merge; the documented verification fixes are present and the metadata and cache changes show no identified user impact. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
v0.12.0was cut at the release merge, and #213 landed onmainshortly after, so the published wheel carries none of the three fixes.git merge-base --is-ancestor 23de2dc v0.12.0says no.That is not a subtle regression. On the document that found it, a support agent with a grant of twelve refunds an hour:
A reader who runs
ctrlrun verifyagainst an ordinary policy today gets one guarantee graded and thirty-one reported not applicable. It reads as a tool that checks nothing, and the failure is silent, so nobody would file it as a bug.Nothing here touches the enforcement path. The whole of it is
verify/scenarios.py, the self-check tool, and it under-reported rather than over-claimed, which is the safe direction. It was severe enough to be worth a patch release anyway.No adapter work. 1.3.0 already declares
ctrlrun>=0.5,<0.13, so 0.12.1 is inside the range both published adapters accept. One tag, no ordering dance.Also in here
adopt-site/removed: two files of empty Vite dependency cache,.vite/deps/package.jsonand a_metadata.jsonwith"optimized": {}, swept into the repository root by #138 and referenced by nothing for four milestones. It shipped in no distribution, but it is the root a reader lands on from the README..vite/andnode_modules/are now in.gitignoreso it cannot come back.Gate and release verification
Docs are
release/0.12.1.🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
X_neqconditions.Release
Chores