0.10.0's release notes were missing a public API addition that ships in it - #198
Conversation
…in it Found by asking, before tagging, whether main still matches what release verification ran against. It does not: one src/ file changed after that check. `needs_approval` gained `task=` and `hop=` in the commit that built two of SPEC-v0.10 section 9.4's three frozen-but-unbuilt rows, which merged after the [0.10.0] section was written. So the release notes for a version that ships the change do not mention it, and a version number on PyPI can never be reused. The change is additive and good: without those parameters the predicate a framework asks before it invokes evaluated against the receiver's whole candidate set while execute evaluates against the hop alone, so it answered "a human is needed" for a call execute then refuses. It was never a wider grant, because Control.execute is the enforcement point and refuses either way. Nothing else in src/ moved since the release verification ran. The adapter version bumps and adapters/PUBLISHED.toml are separate distributions on their own version line, per SPEC-v0.5 section 6.2, and are not kernel release notes. Signed-off-by: arpan <contact@arpanghoshal.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe changelog now documents ChangesNeeds approval release notes
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other Merge Risk: ⚪ Minimal · up to This update accurately documents the shipped API parameters without changing production behavior. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Do not tag until this merges. Found by asking, before tagging, whether
mainstill matches whatrelease verification ran against. It does not.
The gap
needs_approvalgainedtask=andhop=in #191, which built two ofSPEC-v0.10 §9.4'sfrozen-but-unbuilt rows and merged after the
[0.10.0]section was written:So a public API addition ships in 0.10.0 and the release notes do not mention it. A version number
on PyPI can never be reused, which is the whole reason to catch this before the tag rather than
after.
The change itself is additive and good: without those parameters the predicate a framework asks
before it invokes evaluated against the receiver's whole candidate set while
executeevaluatesagainst the hop alone. Never a wider grant, because
Control.executeis the enforcement pointand refuses either way.
Nothing else in
src/moved since verification ran. The adapter version bumps andadapters/PUBLISHED.tomlare separate distributions on their own version line perSPEC-v0.5 §6.2,and are not kernel release notes.
Release verification, from a fresh clone of this branch
Not the working tree.
One thing the verification caught about itself:
test_the_formatter_leaves_markdown_alonefailedon the first pass because the fresh venv had no
ruffand the test shells out to it, so a missingtool read as a formatting violation. Installed and re-run: green. Worth knowing that this test
reports the same way for "ruff says no" and "ruff is absent".
After this merges
Kernel first, so the adapters'
ctrlrun>=0.5,<0.11resolves against a kernel that exists on PyPI.All three version numbers are free there, and all three match their
pyproject.toml.Not merging and not tagging.
Summary by CodeRabbit
New Features
task=andhop=parameters toctrlrun.adapter.needs_approval, enabling approval checks to evaluate the specific execution hop.Documentation