-
Notifications
You must be signed in to change notification settings - Fork 0
Item 4: one declared order, walked by both modes #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7e1cc24
Item 4: one declared order, walked by both modes
arpanghoshal 1a0d49a
Item 5: the operator surfaces for a hop
arpanghoshal 170d45e
Merge pull request #179 from CTRLRun/v0.10/5-operator-surfaces
rohanrkamath d77e2d8
Merge branch 'main' into v0.10/4-one-ordered-list
arpanghoshal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Rank
BUDGET_UNKEYED, and give unlisted reasons a rank of their own._RANKSmaps a reason to its group index, so_UNLISTED_RANKevaluates to_RANKS[NO_AUTHORITY] + 1 == 3, which is the index the(UPSTREAM_MISMATCH, UPSTREAM_UNVERIFIED)group already holds. Two consequences follow:BUDGET_UNKEYEDis a closed-vocabulary reason this module raises through_refuse_unmeasurable, and no group names it. It therefore falls to_UNLISTED_RANKand ties with the upstream group, although enforce mode decides upstream strictly before_charges_for.rule[3]ties with the upstream group for the same reason.blockkeeps the first reason on a tie, so for these pairs the reported reason is decided by the order the checks happen to run in, not by the declared order. RankBUDGET_UNKEYEDwith the other budget reasons, and place the policy axis in its own group so the fallback rank is unoccupied.🐛 Proposed fix
The fallback then needs a rank no group holds, for example a dedicated policy-axis group inserted directly after
REASON_PRECEDENCE:Also applies to: 739-739
🤖 Prompt for AI Agents