The docs job installs the postgres extra, so it counts the suite check runs - #150
Merged
Merged
Conversation
…k runs The readiness block in ctrlrun-docs records what `pytest --collect-only` finds across both checkouts, and the audit fails when a checkout collects fewer tests than the block claims. The docs job installed every extra but `postgres`, and 76 tests exist only when psycopg is importable: 3,461 collected without it against 3,537 with, on the same tree. So the audit has been comparing a block generated with the full suite against a job that could never see all of it, and reporting the block as stale when it was right. The job now installs the same extras as `check`, and a repository-signals test reads both install lines and holds them equal. Signed-off-by: arpan <contact@arpanghoshal.com>
|
Warning Review limit reachedNext included review available in 29 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…h-pinned main moved both jobs onto requirements/*.txt by hash, so the extras this PR added to the docs job's pip line no longer live in the workflow. They live in scripts/lock.sh, and docs.txt now takes --extra postgres exactly as ci.txt does. The test moves with them: it compared two pip install -e .[...] strings in ci.yml and would now read nothing, so it compares the two locks instead and requires docs.txt to cover ci.txt. Signed-off-by: arpan <arpanghoshalwork@gmail.com>
Contributor
|
lgtm |
arpanghoshal
added a commit
to CTRLRun/ctrlrun-docs
that referenced
this pull request
Sep 13, 2026
CTRLRun/ctrlrun#150 put the postgres extra in the docs lock so that job collects the suite the check job runs. It collects five more tests than the block recorded, which the audit does not fail on, because it only fails when the block claims MORE than the suite collects. Understating is still not the number. Signed-off-by: arpan <contact@arpanghoshal.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
CI only. The
docsjob's editable install gains thepostgresextra, matchingcheck, and a repository-signals test holds the two install lines equal.Why. The readiness audit (
render_readiness.py --checkin ctrlrun-docs) fails when the checkout collects fewer tests than the block records. It has failed onmainsince the 0.7.0 block was written: "claims 5,167, collects 5,091". The 76-test gap is exactly the Postgres tests, which are collected only when psycopg is importable. Reproduced on one tree:.[dev,gateway,otel,identity]collects 3,461, addingpostgrescollects 3,537. The block was right; the job was counting a smaller suite thancheckruns.Checklist
test_the_docs_job_installs_the_extras_the_check_job_runsis red onmainand green here.CLAIMS.md. No README sentence changed.docsjob on this PR is the evidence.scripts/check.shgreen for the touched file.src/.Mutation table
postgresremoved from the docs job's install linetest_the_docs_job_installs_the_extras_the_check_job_runs🤖 Generated with Claude Code