Skip to content

The approve-from-your-assistant page back under the 900-word budget - #52

Merged
arpanghoshal merged 1 commit into
mainfrom
mcp-operator-stdio
Sep 16, 2026
Merged

arpanghoshal merged 1 commit into
mainfrom
mcp-operator-stdio

Conversation

@arpanghoshal

@arpanghoshal arpanghoshal commented Sep 16, 2026

Copy link
Copy Markdown
Member

Docs main went red after #51 merged, on two tests. This fixes the one that is mine: the stdio wording pass took docs/mcp/approve-from-your-assistant.mdx to 904 words of prose against the site's 900-word budget. Forty-odd words trimmed, no fact removed.

The other failure, cli.mdx versus click's help text, is the pairing order: #51 merged before its kernel counterpart CTRLRun/ctrlrun#228, so docs main now describes a --stdio flag that kernel main does not have yet. It clears the moment #228 merges, and reverting it would break again right after. This PR is on the same paired branch name, so its CI checks against the kernel branch and comes back green on both.

Summary by CodeRabbit

  • Documentation
    • Clarified that the core installation is sufficient for stdio usage.
    • Documented the store location relative to CTRLRUN_CONFIG.
    • Added explicit details about read-only access for root and sudo users.
    • Clarified that stdio logins do not expire.
    • Documented that approver_role, header, JWT, and origin controls are refused over stdio.

The stdio wording pass took it to 904 words of prose. Forty-odd trimmed, no fact removed:
the two things a person should know before relying on the login stay as they were.

Signed-off-by: arpan <contact@arpanghoshal.com>
@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: dd4d7725-a9ed-4143-acc9-872d2bf58845

📥 Commits

Reviewing files that changed from the base of the PR and between adcc1b6 and eb0aac5.

📒 Files selected for processing (1)
  • docs/mcp/approve-from-your-assistant.mdx

Included review availability: Your plan provides up to 10 included reviews per hour; 4 remain after this review.


📝 Walkthrough

Walkthrough

The stdio documentation now clarifies installation, store placement, root-account access, no-expiry login behavior, and refusal of approver_role, header, JWT, and origin flags.

Changes

Stdio documentation

Layer / File(s) Summary
Stdio setup rules
docs/mcp/approve-from-your-assistant.mdx
The documentation states that the core install is sufficient, clarifies store placement beside CTRLRUN_CONFIG, separates no-expiry and root-account rules, and explicitly refuses unsupported flags.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to eb0aa

The documentation-only update is ready to merge with no identified actionable risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: reducing the approve-from-your-assistant page to meet the 900-word budget.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mcp-operator-stdio

Warning

Git: CodeRabbit could not clone the repository, so clone-backed analysis was skipped and this review may be incomplete. Verify repository clone access, such as SSH credentials, before requesting another full review. If clone access is intentionally unavailable, use path_filters to narrow the review scope.


Comment @coderabbitai help to get the list of available commands.

@mintlify

mintlify Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
ctrlrun 🟢 Ready View Preview Sep 16, 2026, 9:37 AM

💡 Tip: Enable Automations to automatically generate PRs for you.

@arpanghoshal
arpanghoshal merged commit 11958b0 into main Sep 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant