Skip to content

The deleted pages were still in the navigation - #44

Merged
arpanghoshal merged 1 commit into
mainfrom
site/nav-leftovers
Sep 15, 2026
Merged

arpanghoshal merged 1 commit into
mainfrom
site/nav-leftovers

Conversation

@arpanghoshal

@arpanghoshal arpanghoshal commented Sep 15, 2026

Copy link
Copy Markdown
Member

#43 removed protect-my-agent.mdx and risk-check.mdx, cleaned the navbar and added redirects, and left both in docs.json's navigation. The site rebuilt with two sidebar entries pointing at pages that no longer exist:

{"tab": "CTRLRun", "pages": ["index", "execution-boundary", "risk-check", "protect-my-agent"]}

Nothing caught it. links.py reads Markdown links in page bodies; the check job validates the schema. A navigation entry naming a missing page is outside both, and the full gate was green with the defect in place.

I found it by fetching the deployed home page and grepping for the words that were supposed to be gone. That is the only check that was ever going to see this, and it is worth remembering for the next structural change: green locally is not the same as correct in the browser.

all checks passed             (ruff, ruff format, 1711 passed)
links 190 documents 0 broken

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated CTRLRun navigation to show only the Index and Execution Boundary pages.
    • Removed links to the Risk Check and Protect My Agent pages.

#43 removed `protect-my-agent.mdx` and `risk-check.mdx`, cleaned the navbar
and added redirects, and left both in `docs.json`'s `navigation`. The site
rebuilt with two sidebar entries pointing at pages that no longer exist.

Nothing caught it. `links.py` reads Markdown links in page bodies and the
`check` job validates the schema, so a navigation entry naming a missing page
is outside both. I found it by fetching the deployed home page and grepping for
the words that were supposed to be gone, which is the only check that was ever
going to see it.

Signed-off-by: arpan <contact@arpanghoshal.com>
@mintlify

mintlify Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
ctrlrun 🟢 Ready View Preview Sep 15, 2026, 12:39 AM

💡 Tip: Enable Automations to automatically generate PRs for you.

@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 88dd0344-1ac3-4b3a-9622-9a6f20446d2a

📥 Commits

Reviewing files that changed from the base of the PR and between 0221244 and 0d6a9eb.

📒 Files selected for processing (1)
  • docs.json

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The CTRLRun tab navigation now contains only index and execution-boundary. The risk-check and protect-my-agent pages were removed.

Changes

CTRLRun navigation

Layer / File(s) Summary
Update CTRLRun page list
docs.json
The CTRLRun tab retains index and execution-boundary and removes risk-check and protect-my-agent.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 0d6a9

No actionable merge-blocking risk is evident in this navigation-only change.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: removing deleted pages from the navigation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch site/nav-leftovers

Comment @coderabbitai help to get the list of available commands.

@arpanghoshal
arpanghoshal merged commit abf18b3 into main Sep 15, 2026
3 checks passed
@arpanghoshal
arpanghoshal deleted the site/nav-leftovers branch September 15, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant