The deleted pages were still in the navigation - #44
Conversation
#43 removed `protect-my-agent.mdx` and `risk-check.mdx`, cleaned the navbar and added redirects, and left both in `docs.json`'s `navigation`. The site rebuilt with two sidebar entries pointing at pages that no longer exist. Nothing caught it. `links.py` reads Markdown links in page bodies and the `check` job validates the schema, so a navigation entry naming a missing page is outside both. I found it by fetching the deployed home page and grepping for the words that were supposed to be gone, which is the only check that was ever going to see it. Signed-off-by: arpan <contact@arpanghoshal.com>
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe ChangesCTRLRun navigation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to No actionable merge-blocking risk is evident in this navigation-only change. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
#43 removed
protect-my-agent.mdxandrisk-check.mdx, cleaned the navbar and added redirects, and left both indocs.json'snavigation. The site rebuilt with two sidebar entries pointing at pages that no longer exist:Nothing caught it.
links.pyreads Markdown links in page bodies; thecheckjob validates the schema. A navigation entry naming a missing page is outside both, and the full gate was green with the defect in place.I found it by fetching the deployed home page and grepping for the words that were supposed to be gone. That is the only check that was ever going to see this, and it is worth remembering for the next structural change: green locally is not the same as correct in the browser.
🤖 Generated with Claude Code
Summary by CodeRabbit