The gateway's -41002 example was stale, and understated what the client does - #42
Merged
Merged
Conversation
…t does The documented error said `mcp.ops.delete_namespace: a human must approve`. The gateway actually emitted the decorator's wording, telling an MCP client to retry inside `ctrlrun.with_approval(...)`, a Python context manager it has no access to. The kernel PR fixes the message; this fixes the example, and adds the `data` fields the gateway really sends. The prose already said the right thing, that the agent's next identical call runs. It now says explicitly that there is nothing for the client to do differently, because that is the sentence whose absence let the wrong error text look plausible for four milestones. Signed-off-by: arpan <contact@arpanghoshal.com>
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
|
Warning Review limit reachedNext included review available in 12 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pairs with ctrlrun#211.
The documented error read
"mcp.ops.delete_namespace: a human must approve". What the gateway actually emitted was the decorator's wording, telling an MCP client to retry insidectrlrun.with_approval(...), a Python context manager it has no access to. The kernel PR fixes the message; this fixes the example, and adds thedatafields the gateway really sends (action_hash,expires_at).The prose already said the right thing, that the agent's next identical call runs. It now says explicitly that there is nothing for the client to do differently on the retry, and that the decorator's second step does not apply here. That missing sentence is what let the wrong error text look plausible.
Found by running a real MCP server with the gateway in front of it, not by reading.
🤖 Generated with Claude Code