v0.11 item 5: coverage, and where the answer actually comes from - #35
Merged
Merged
Conversation
postgres.md has said since v0.6 that this library has no retention policy, in the same breath as the reason one is hard. That is the claim item 3 pays. The retention page states two things the ROADMAP line did not: the ledger rule is settlement and then a window rather than 'un-released', and the window is supplied on the command line rather than derived, because a store that resolved a grant's budgets would be reading the policy. Signed-off-by: arpan <contact@arpanghoshal.com>
ROADMAP's v0.11 line said 'from events already written', and the action name is NOT on the event: ACTION_PROPOSED carries an action_hash and nothing that maps it back. The answer comes from receipts, which every decided action leaves, a denial included, which is why an action that is always denied counts as exercised. CLAIMS.md's scan row said 'no score, no percentage and no badge'. --coverage opens a store and still computes none, and the row now says so with the tests that pin it. Signed-off-by: arpan <contact@arpanghoshal.com>
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
|
Warning Review limit reachedNext included review available in 54 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (23)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pairs with CTRLRun/ctrlrun#204, on a branch of the same name. v0.11 item 5: enforcement coverage.
Stacks on item 3's docs branch (#34).
A correction the build earned
ROADMAP.md's v0.11 line said enforcement coverage comes "from events already written". It does not, and the difference decides the design.ACTION_PROPOSEDcarries anaction_hashand nothing that maps it back to a name, so the answer comes from receipts, which every action that reached a decision leaves.The line now says so, and says the consequence: a receipt is written for a denial too, which is why an action that is always denied counts as exercised rather than as a gap. Reporting it as never exercised would tell an operator to delete the deny rule that is working.
CLAIMS.mdThe
ctrlrun scanrow claimed "has no score, no percentage and no badge".--coverageopens a store, which the same row also claims scan never does, so both halves of that sentence needed saying properly: the static half still opens nothing, and the runtime half opens a store and still computes no number. The row names the two tests that pin it,T560andT563.OWASP-SOLUTIONS-LANDSCAPE.mdTwo rows gain the runtime half. The SAST/DAST row is the one worth reading, because it is the one a reader could mistake for a coverage percentage: it now says plainly that neither half produces a number, and that a policy entry nothing exercised may be correctly unused.
Generated
docs/reference/cli.mdxpicks up--coveragefrom the command's own help text. Every generator re-run against the item 5 kernel branch in an environment built the way docs CI builds one;repoint-claims.pyre-pointed 0. Readiness: 6,201 tests. The kernel worktree came back clean.Checks
./scripts/check.sh: 1727 passed.🤖 Generated with Claude Code