Regenerate the API reference against v0.10 items 1 to 5 - #14
arpanghoshal wants to merge 1 commit into
Conversation
19 pages, 23 lines. Line numbers moved because items 1 to 5 added code, and four signatures gained a parameter: Control.__init__ gained upstream (SPEC-v0.10 section 4.3, the surface that holds the connection is the one that can name it), protect and Control.execute gained hop, Receipt gained hop, and AuthorityResult gained hop. No page was added or removed, and that is correct rather than an omission. narrowed_dimensions and unmatched_shape live in ctrlrun.authority.__all__ and not in ctrlrun.__all__, which is where render_api.py takes its names from; contained_dimension and DIMENSIONS are in exactly the same position and have no pages either. Control.hop is a method and renders inside Control.mdx. All seven generators clean against the stack: capabilities, cli, schemas, api, cookbook, readiness, badges. Signed-off-by: arpan <contact@arpanghoshal.com>
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (19)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe API reference pages update source-definition links and document signature changes for ChangesAPI reference synchronization
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to This documentation-only synchronization is ready to merge with no identified user or production impact. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Superseded. This branch was regenerated against the whole v0.10 stack, so it could not be green against the kernel's main until every item merged, and the kernel's runs could not be green against this repository's main until this merged: each side waiting for the other. The replacement is one branch here per kernel branch, named the same, each checked against the other by the CI change in #15: #15 (CI rule plus items 1 and 2, already on the kernel's main), #16 (item 3, G27), #17 (item 4), and v0.10/5-operator-surfaces pushed without a PR because item 5 changes no page. Merge order follows the kernel's. The branch is left in place. |
The fix for the
docscheck that is red onCTRLRun/ctrlrun#175 to #179.What drifted, and why
Items 1 to 5 changed docstrings and moved line numbers, so the generated API pages no longer match
the library. 19 pages, 23 lines: line numbers, plus four signatures that gained a parameter.
Control.__init__upstream(§4.3: the surface holding the connection is the one that can name it)protect,Control.execute,Control.evaluatehopReceipthop(ctrlrun.receipt/v7)AuthorityResulthopNo page was added or removed, and that is correct rather than an omission.
narrowed_dimensionsandunmatched_shapeare inctrlrun.authority.__all__and not inctrlrun.__all__, which is whererender_api.pytakes its names from — andcontained_dimensionand
DIMENSIONSsit in exactly that position with no pages either.Control.hopis a method andrenders inside
Control.mdx.All seven generators are clean against the stack:
capabilities,cli,schemas,api,cookbook,readiness,badges.Merge order, because there is a circular dependency and it is worth stating
This repository's CI audits these pages against
CTRLRun/ctrlrun's default branch, andctrlrun'sdocsjob audits its source against this repository's default branch. So:ctrlrunstack first — #175, #176, #177, #178, #179, bottom-up. Everyrequired check (
check (3.11),check (3.12),package) is green on all five;docsisadvisory and stays red through the stack.
ctrlrun'smaincarries items 1 to 5.ctrlrun'sdocsjob then goes green onmain.A five-PR stack cannot all be docs-green at once, because the generated pages are a function of
one source state: pages matching the full stack necessarily differ from #175's source, which has
none of the items. That is a property of the split-repo audit, not something this PR can work
around.
Summary by CodeRabbit
hopparameters for relevant authority and protection APIs.upstreamparameter for controls.